Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config option REACT_APP_URL_BASENAME #431

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

gabalafou
Copy link
Contributor

Description

This change should have been made with Bye tabs, hi URLs #389. That PR introduced URL routing to the app, assuming that the React app would always be mounted in the browser at the root path, "/". But the Conda Store server supports a URL prefix, which means that the UI app in such deployments, might be mounted at some path other than root, such as "/conda-store", for example loading the UI at https://example.com/conda-store instead of just https://example.com.

This pull request:

  • Introduces a new configuration variable: REACT_APP_URL_BASENAME (which maps directly to React Router browser router opts.basename)

Pull request checklist

  • Did you test this change locally?
  • Did you update the documentation (if required)?
  • Did you add/update relevant tests for this change (if required)?

@trallard
Copy link
Collaborator

Thank you! will merge so I can test with server and UI!

@trallard trallard merged commit 0cb7011 into conda-incubator:main Oct 21, 2024
6 checks passed
@gabalafou gabalafou deleted the url-basename branch October 21, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants